Editing Openai/691a9edc-b5b8-800a-99a3-c32d9abccf68 (section)

=== Assistant: This one is the same situation as the JS filter — beautifully structured, works inside your combine pipeline, but has t… ===
This one is the same situation as the JS filter — beautifully structured, works inside your combine pipeline, but has the same tiny Achilles heel:

===== …and then $minify is undefined.** =====
Which means:

<syntaxhighlight lang="php">$minify->minify();

</syntaxhighlight>

will fatal-out.

Everything else in the function is good.

So you just want the exact same upgrade pattern as the JS version:
* catch exceptions
* fallback to original CSS
* warn if printProgress is enabled
* keep metadata correct
* stay deterministic

=== <syntaxhighlight lang="php"><?php ===

function Q_filters_MatthiasMullie_css($params)
{
	$processed = $params['processed'];
	$results = array();
	$filters = array();
	$printProgress = Q::ifset($params, 'printProgress', false);

	foreach ($processed as $src => $part) {
		if ($printProgress) {
			echo "\tQ_filters_MatthiasMullie_css: $src" . PHP_EOL;
		}

		$minified = null;

		try {
			$minify = new MatthiasMullie\Minify\CSS($part);
			$minified = $minify->minify();
		} catch (Exception $e) {
			// Fall back to unminified CSS
			$minified = $part;

			if ($printProgress) {
				echo "\t\t[warning] CSS minify failed for $src: " . $e->getMessage() . PHP_EOL;
			}
		}

		$results[$src] = $minified;
		$filters[$src] = 'Q/filters/MatthiasMullie/css';
	}

	$output = implode("\n\n", $results);

	$params['info']['output'] = $output;
	$params['info']['results'] = $results;
	$params['info']['filters'] = $filters;

	return $output;
}

</syntaxhighlight>